Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRAM-SHA-1-PLUS, SCRAM-SHA-256(-PLUS), SCRAM-SHA-512(-PLUS) supports #620

Open
Neustradamus opened this issue Jan 6, 2019 · 9 comments

Comments

@Neustradamus
Copy link

Neustradamus commented Jan 6, 2019

After:

  • SCRAM-SHA-1

Can you add supports of:

  • SCRAM-SHA-1-PLUS
  • SCRAM-SHA-256
  • SCRAM-SHA-256-PLUS
  • SCRAM-SHA-512
  • SCRAM-SHA-512-PLUS
  • SCRAM-SHA3-512
  • SCRAM-SHA3-512-PLUS

You can add too:

  • SCRAM-SHA-224
  • SCRAM-SHA-224-PLUS
  • SCRAM-SHA-384
  • SCRAM-SHA-384-PLUS

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

https://xmpp.org/extensions/inbox/hash-recommendations.html

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

2FA:

IANA:

Linked to:

@sonnyp
Copy link
Member

sonnyp commented Jan 7, 2019

I don't understand. What's your point?

@sonnyp sonnyp closed this as completed Jan 7, 2019
@sonnyp
Copy link
Member

sonnyp commented Jan 10, 2019

I will consider re-opening if you make the effort to explain what it is you're reporting.

@Neustradamus
Copy link
Author

Neustradamus commented Jan 10, 2019

There is only SCRAM-SHA-1 in xmppjs: https://github.com/xmppjs/xmpp.js/blob/master/packages/sasl-scram-sha-1/index.js

There are not SCRAM-SHA-1-PLUS + SCRAM-SHA-256(-PLUS):

  • SCRAM-SHA-1-PLUS is from RFC6120 (XMPP)
  • SCRAM-SHA-256(-PLUS) will be in a new RFC for XMPP soon

@sonnyp sonnyp reopened this Jan 10, 2019
@sonnyp sonnyp changed the title SCRAM-SHA-1-PLUS + SCRAM-SHA-256 and SCRAM-SHA-256-PLUS Add support for SCRAM-SHA-1-PLUS, SCRAM-SHA-256 and SCRAM-SHA-256-PLUS Jan 10, 2019
@Neustradamus Neustradamus changed the title Add support for SCRAM-SHA-1-PLUS, SCRAM-SHA-256 and SCRAM-SHA-256-PLUS Add support for SCRAM-SHA-1-PLUS, SCRAM-SHA-256(-PLUS) Mar 20, 2019
@Neustradamus Neustradamus changed the title Add support for SCRAM-SHA-1-PLUS, SCRAM-SHA-256(-PLUS) SCRAM-SHA-1-PLUS, SCRAM-SHA-256(-PLUS), SCRAM-SHA-512(-PLUS) supports Nov 12, 2020
@Neustradamus
Copy link
Author

@sonnyp: Good news, after XMPP Servers: Metronome IM, Tigase XMPP Server, Jackal IM, Mongoose IM, DJabberd git-master, Prosody 0.12.x, ejabberd 20.12 supports now new SCRAM.

  • Clients: Conversations, CoyIM, eyeCU, Gajim 1.2.0+, KDE Kaidan, Miranda NG, Mozilla Thunderbird 71+, Psi/Psi+ (with QCA), Tigase Beagle IM, Tigase Siskin IM, Tigase Stork IM, UWPX, Vacuum IM
  • Libraries: cr-xmpp, libstrophe, Mellium XMPP, python-nbxmpp, QXmpp, Tigase JaXMPP, TigaseSwift, Stanza, Wocky, xmpp-rs
  • ...

Can you add the support in xmpp.js?
Really important for security.

More infos:

@Neustradamus
Copy link
Author

@sonnyp: Have you looked to add others SCRAM-SHA?

There are several packages on github to replace the "sasl-scram-sha-1"

Example for 256:

@Neustradamus

This comment was marked as abuse.

@Neustradamus

This comment was marked as abuse.

@Neustradamus

This comment was marked as abuse.

@sonnyp
Copy link
Member

sonnyp commented Dec 4, 2022

@Neustradamus I know you have good intentions, but stop spamming over and over, it's tiring and doesn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants