Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make nhooyr.io ping/pong timeouts configurable #83

Closed
denopink opened this issue Apr 12, 2024 · 0 comments · Fixed by #113
Closed

feat: make nhooyr.io ping/pong timeouts configurable #83

denopink opened this issue Apr 12, 2024 · 0 comments · Fixed by #113
Assignees
@denopink
Labels
enhancement improvement or small functionality added to an existing feature

Comments

@denopink
Copy link
Contributor

No description provided.

@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Apr 12, 2024
denopink added a commit that referenced this issue May 3, 2024
@denopink
feat: implement configurable ping timeout for nhooyr.io/websocket #83
924a2c6 
- added `pingTimeout   time.Duration` to `internal/nhooyr.io/websocket/conn.go`'s `Conn struct`
- implemented `SetPingTimeout`, following how `nhooyr.io/websocket` exposes configurable conn values
- if `conn`'s `pingTimeout` is nonpositive, then use `handleControl`'s 5 second timeout https://github.com/xmidt-org/xmidt-agent/blob/78dffe0cad394ab82f581940e3a8117f04941077/internal/nhooyr.io/websocket/read.go#L301
@denopink denopink linked a pull request May 7, 2024 that will close this issue
feat: implement configurable ping timeout for nhooyr.io/websocket #113
Merged
@denopink denopink self-assigned this May 7, 2024
@denopink denopink mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denopink denopink

Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement configurable ping timeout for nhooyr.io/websocket xmidt-org/xmidt-agent
1 participant
@denopink