Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talaria.yaml uses incorrect inbound timeout key #358

Closed
iganev0886 opened this issue Nov 10, 2023 · 1 comment · Fixed by #357
Closed

talaria.yaml uses incorrect inbound timeout key #358

iganev0886 opened this issue Nov 10, 2023 · 1 comment · Fixed by #357
Assignees

Comments

@iganev0886
Copy link
Contributor

I believe that requestTimeout here https://github.com/Enterprise-RDK/talaria/blob/main/talaria.yaml#L326 should be actually timeout since the primary handler uses the path inbound.timeout: https://github.com/Enterprise-RDK/talaria/blob/main/primaryHandler.go#L91

I am new to this codebase and I might be wrong, but since we had issues with one of our devices taking longer than 120s to process a specific request, we found that actually timeout is the correct value to set.

Kind regards, Ivo

@denopink
Copy link
Contributor

yup, looks like this fell between the cracks. talaria.yaml serves as an example talaria config, we'll take a look and verify the rest is correct via #359

Please sign the cla in your pr #357 and we can merge 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants