Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partnerIDs to internal webhook store #99

Open
joe94 opened this issue May 20, 2020 · 0 comments
Open

Add partnerIDs to internal webhook store #99

joe94 opened this issue May 20, 2020 · 0 comments
Labels
argus-webhooks Securing webhooks for the switch to argus
Projects

Comments

@joe94
Copy link
Member

joe94 commented May 20, 2020

Context

Currently, we are not filtering events based on partnerIDs but with the switch to argus as the webhook storage strategy, we'd like to add a configuration option to filter events by such values.

Task:

To do that (xmidt-org/caduceus#181), caduceus needs access to the partnerIDs the listener registered with. On webhook registration, the value needs to be captured and saved as part of a registration

If JWT validation is enabled, the list(string) value will come from the claim allowedResources.allowedPartners

If JWT validation is not enabled, a header based fall back should be provided (As an example, Tr1d1um already does this: https://github.com/xmidt-org/tr1d1um/blob/b117f90bda5d29cea5283da3abee1165cfbf4921/translation/transport.go#L94)

@joe94 joe94 added the argus-webhooks Securing webhooks for the switch to argus label May 20, 2020
@joe94 joe94 added this to To review in XMiDT May 20, 2020
@joe94 joe94 moved this from To review to Reviewed in XMiDT May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argus-webhooks Securing webhooks for the switch to argus
Projects
XMiDT
  
Reviewed
Development

No branches or pull requests

1 participant