Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure gauge for outbound queue is 0 on startup #203

Open
kristinapathak opened this issue May 12, 2020 · 1 comment
Open

Make sure gauge for outbound queue is 0 on startup #203

kristinapathak opened this issue May 12, 2020 · 1 comment
Assignees
Labels
Projects

Comments

@kristinapathak
Copy link
Contributor

kristinapathak commented May 12, 2020

c.queueDepthGauge = m.NewGauge(OutgoingQueueDepth).With("url", c.id)

Instead of making new gauges and other metrics for each outbound sender, we should create these once for caduceus and then pass what is needed to the outbound senders.

Then, we can easily set the gauge to 0 on startup, which hopefully will fix the issue of the gauge getting stuck on a specific queue depth that doesn't look correct:
Screen Shot 2020-05-12 at 1 14 19 PM

Edit: this is unlikely to fix the gauge issue, but would still be a nice fix to make.

@kristinapathak kristinapathak added this to the Unreleased milestone May 12, 2020
@kristinapathak kristinapathak self-assigned this May 12, 2020
@kristinapathak kristinapathak removed this from the Unreleased milestone May 18, 2020
@kristinapathak
Copy link
Contributor Author

Setting the gauge to 0 for each label was done in this pr:
#205

Fixing the metrics to create counters and metrics once instead of in a variety of different structs can be done at a later time. This will probably be partially or completely done as a part of moving to uber.fx or creating a separate library for the outbound sender.

@kristinapathak kristinapathak added this to Reviewed in XMiDT May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
XMiDT
  
Reviewed
Development

No branches or pull requests

1 participant