Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage stats are not full #58

Open
ocvit opened this issue Feb 6, 2024 · 2 comments
Open

Coverage stats are not full #58

ocvit opened this issue Feb 6, 2024 · 2 comments

Comments

@ocvit
Copy link
Contributor

ocvit commented Feb 6, 2024

I've compared current coverage stats with full catalog from Redump and it looks like the total counts are mostly lower than expected.

The number of image files in repo is also out of sync. As well as missing_covers.txt registry.

Serial Found Files in repo Total Total (Redump) Missing Missing (.txt) Missing (Redump)
SLPS 3012 3092 3146 3483 134 127 471
SLES 2253 2256 2309 2654 56 54 401
SLPM 1095 1118 1571 1627 476 477 532
SLUS 1209 1211 1310 1558 101 103 349
SCES 590 591 615 729 25 25 139
SCPS 387 400 417 352 30 30 0
SCUS 184 185 379 433 195 199 249
SCED 0 0 349 361 349 349 361
SLED 0 0 223 238 223 223 238
LSP 23 24 118 206 95 95 183
PCPX 2 2 107 128 105 105 126
PAPX 1 3 59 78 58 58 77
SIPS 18 18 18 21 0 0 3
PBPX 0 0 13 15 13 11 15
SCZS 0 0 6 6 6 6 6
SLKA 2 2 3 3 1 1 1
ESPM 3 3 3 3 0 0 0
SCPM 0 0 3 4 3 3 4
HPS 2 2 2 0 0 0 0
CPCS 2 1 2 0 0 0 0
PUPX 0 0 2 2 2 2 2
SCEs 1 0 1 0 0 0 0
SCAJ 1 1 1 0 0 0 0
PL 0 0 1 0 1 1 0
PCPD 0 0 1 1 1 1 1
PEPX 0 0 1 1 1 1 1
PSRM 0 0 1 1 1 1 1
PTPX 0 0 1 1 1 1 1

Also, there are few serial types that were not mentioned before:

Serial Total (Redump)
Part 20
DTL 5
SPUS 1
PSX0005 1
PSXCDCLEAN 1
KRT 1
DK 1

These serial types are not present on Redump:

Serial Found Files in repo Total Total (Redump)
HPS 2 2 2 0
CPCS 2 1 2 0
SCEs 1 0 1 0
SCAJ 1 1 1 0
PL 0 0 1 0

I'm really curious about SCEs as it seems like a non-normalized SCES and it's not even present in missing_covers.txt.


Anyway, is anybody in charge of these stats? And is this repo alive?

@xlenore
Copy link
Owner

xlenore commented Feb 6, 2024

Hello, for this repo I used Duckstation gamedb.json file.

@ocvit
Copy link
Contributor Author

ocvit commented Feb 7, 2024

Hi @xlenore,

Duckstation uses an approach of merging multiple editions of game into a single serial. It might work for ISOs with the same CRC, but it's a bad thing for us, because those editions might have completely different covers.

For example, Colin McRae Rally (PAL) [ITA] was released in 4 editions:

  • SLES-01204 - Original
  • SLES-01204# - Platinum
  • SLES-01204#2 - Value Series
  • SLES-01204#3 - Bestsellers

Here is Original:
orig

And here is Platinum:
plat

And they're simplified to a single SLES-01204 in gamedb.yaml.


So is this repo Duckstation-specific, i.e. we should have games they support and in a format they prefer only? Or this should be a bigger and more accurate catalog of covers?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants