Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private key shown in loggings #14

Open
DeveloperAnonymous opened this issue Nov 29, 2021 · 0 comments
Open

Private key shown in loggings #14

DeveloperAnonymous opened this issue Nov 29, 2021 · 0 comments

Comments

@DeveloperAnonymous
Copy link

Hello!

Well, I know there is clearly ways to work around this, but it's not really safe in my opinion to print out the private key in the logs.

I know. I can change the logging level to something higher than info for the module, but I just don't think, in any cases, the key should be printed in any type of loggings (maybe debug)

Talking about debug. I don't think a query should be logged at the "info" level but the "debug"
INFO:pyxivapi.client:200 from https://xivapi.com/search?language=en&private_key=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant