Make syntect plugin (and rust plugin lib) 'global' #472
Labels
Comments
This was referenced Mar 15, 2018
Closed
Merged
cmyr
added a commit
that referenced
this issue
Mar 23, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 23, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 23, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 26, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 26, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 28, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 28, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Mar 29, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Apr 3, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
cmyr
added a commit
that referenced
this issue
Apr 3, 2018
This shouldn't be merged as is, but is a working demo of syntect running globally; that is, using this plugin a single instance of syntect will handle highlighting for all open views. To use this with xi-mac, build-rust-xcode.sh will have to be modified so that the `--features=global` flag is passed to cargo when compiling syntect. Alternatively, you can modify syntect/src/main.rs to use the global code path by default. Known issues: - none of the indentation code is ported, so autoindent won't work - the idle handler has no concept of priority, so if a big file is being processed in the background text entered in another buffer can end up not being processed immediately. In some instances it may not be processed at all. If eventually merged, this closes #472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently each document has its own copy of syntect running in a distinct process. This causes a delay before highlighting kicks in on a newly opened document, and increases overhead.
We have the concept of global plugins, but they aren't supported by the rust plugin lib.
A relevant question at this point, though: do we ever really need to support local plugins? @trishume's #374 outlines an approach to having at most a single process per plugin, which seems reasonable.
The text was updated successfully, but these errors were encountered: