Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move editing functions out of editor.rs #1199

Closed
cmyr opened this issue Jun 22, 2019 · 6 comments
Closed

Move editing functions out of editor.rs #1199

cmyr opened this issue Jun 22, 2019 · 6 comments

Comments

@cmyr
Copy link
Member

cmyr commented Jun 22, 2019

Similar to #1198, we would like to be able to use editing functions independently of an Editor or a runloop.

For more detail, see #1187. For an illustration of how this could be done, see the edit_ops mod in the xi-modal branch. (Note that having this be in a submodule of editor.rs isn't desirable long term).

A goal of this work should be to make it much easier to write simple tests of various edit operations.

@cmyr cmyr added this to To do in editor toolkit via automation Jun 22, 2019
@KeeganMyers
Copy link

I am a relative beginner to rust and completely new to the code base. Would this be a decent 1st PR opportunity or should I look into another issue? If so I can probably start looking at this over the weekend.

@cmyr
Copy link
Member Author

cmyr commented Aug 8, 2019

This is definitely a little bit of a project, but it isn't crazy, and the linked resources will be useful. It would certainly be a good way to become more familiar with the codebase.

@Iamshankhadeep
Copy link

I am new to this community and rust, Can I work on this issue?

@nangtrongvuon
Copy link
Member

@Iamshankhadeep Sure, feel free to dive into this and ask around on the xi zulipchat if you need help!

@TDecking TDecking mentioned this issue Apr 27, 2020
4 tasks
@TDecking
Copy link
Collaborator

TDecking commented May 1, 2020

I think this issue can be closed now.

@LiHRaM
Copy link
Contributor

LiHRaM commented Jun 2, 2020

Yep!

@LiHRaM LiHRaM closed this as completed Jun 2, 2020
editor toolkit automation moved this from To do to Done Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants