Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Rendering issue with icons #9

Closed
lbwexler opened this issue Nov 19, 2021 · 7 comments
Closed

Intermittent Rendering issue with icons #9

lbwexler opened this issue Nov 19, 2021 · 7 comments

Comments

@lbwexler
Copy link
Member

Reported by a client recently, but also seen intermittently over the past few months by many team members

See FortAwesome/Font-Awesome#17644

@lbwexler
Copy link
Member Author

From ATM:

FWIW we do have in our static HTML that serves up the CSS/JS, but looking at the compiled CSS files for e.g. toolbox some have @charset "UTF-8"; at the top and others don’t - not really sure where that comes from (or fails to come from)

Also - are those blueprint checkboxes that are getting corrupted? Probably so - our use of FA creates inline SVGs for each icon - but I bet the BP icons are using the same approach as the FA bug report

@lbwexler
Copy link
Member Author

Client reporting had:

"dependencies": {
"@xh/hoist": "42.6.0",
},
"devDependencies": {
"@xh/hoist-dev-utils": "5.9.3",

}

@amcclain
Copy link
Member

Requested client try nginx directive like so:

xh/toolbox@14720ca

to ensure CSS served up with utf-8 charset. If this a) does not cause any other problems and ideally b) results in this problem going away, we can bake into our base image. (https://github.com/xh/xh-nginx)

@amcclain
Copy link
Member

amcclain commented Dec 1, 2021

@cnrudd - we just heard back from the client that they will give this a try - could you please keep this on your radar and check back with them in a week or so if we don't hear back one way or another first?

@cnrudd
Copy link
Member

cnrudd commented Dec 1, 2021

@amcclain I have added a note in my calendar to reach out to them next Wednesday.

@ghost ghost assigned amcclain and unassigned cnrudd Dec 15, 2021
@amcclain amcclain transferred this issue from xh/hoist-react Dec 15, 2021
@amcclain
Copy link
Member

I'll bake this into our base image here - still waiting to get confirm from client if they see it again, but if safe it's best to have it built in.

@amcclain
Copy link
Member

Screen Shot 2022-01-14 at 9 52 41 AM

Screen Shot 2022-01-14 at 9 52 54 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants