Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing module.properties entry module.description results in invalid amp #69

Open
todorinskiz opened this issue Aug 25, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@todorinskiz
Copy link
Member

Creating a vanila AMP, as is out-of-the-box from eu.xenit.amp, without specifying project description results in invalid AMP:

07250000 The following module properties need to be defined: [module.description]

Shouldn't we fallback to an empty string?

@thijslemmens
Copy link
Contributor

07250000 The following module properties need to be defined: [module.description]

Is that the error you get when building the amp? Because in that case, I think that's pretty reasonable.

@vierbergenlars
Copy link
Member

No, you get that error when applying the AMP.

See also #56 for failing the build when your AMP is missing properties, which I prefer above letting you get away with not setting a description.

@thijslemmens
Copy link
Contributor

I agree, the build should fail with a clear message. An empty description is not clean.

@vierbergenlars vierbergenlars added the enhancement New feature or request label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants