Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split addOrDeleteRules #34

Open
Jamelle-Boose opened this issue Jul 30, 2022 · 1 comment
Open

split addOrDeleteRules #34

Jamelle-Boose opened this issue Jul 30, 2022 · 1 comment

Comments

@Jamelle-Boose
Copy link

addRule(), deleteRule()

vs

addOrDeleteRules()

It just makes sense. Even the shape of the request is different. With deleting I have to send an array of strings, but with adding I have to send an array of objects with value and tag properties.
@Jamelle-Boose
Copy link
Author

OR, (which would be great), allow us to delete a rule by tag as well as id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jamelle-Boose