14 add dataprovider support #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
AB-xdev
requested changes
Mar 14, 2023
Comment on lines
+694
to
+697
| private List<T> extractItemsFromDataProvider(final DataProvider<T, ?> dataProvider) | ||
| { | ||
| return dataProvider.fetch(new Query<>()).collect(Collectors.toList()); | ||
| } |
There was a problem hiding this comment.
I don't think we should do this like this. Here we're reading all the data from the Dataprovider.
A dataprovider can contain huge amounts of data and was likely designed with the thought that not all that data should be in memory at once.
Is there a different solution for handling the problem? Because this solution yields no improvements in my eyes.
|
Closed as PR is stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.