Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 small problems... #2232

Open
wxlg1117 opened this issue Dec 7, 2022 · 4 comments
Open

2 small problems... #2232

wxlg1117 opened this issue Dec 7, 2022 · 4 comments

Comments

@wxlg1117
Copy link

wxlg1117 commented Dec 7, 2022

Snipaste_2022-12-08_00-10-20

edge 108.0.1462.42:
1,Only 9 rows are shown in the list, the horizontal position of 1 row cannot be scrolled down to expand to show more rows;

2,I can't seem to find the description here sort by what?
All my tabs were originally arranged according to the opening time, but I accidentally clicked, I feel that the order is all messed up.

Finally, the overall feeling is better than quick tabs, thanks to the author

@xcv58
Copy link
Owner

xcv58 commented Dec 8, 2022

1, Only 9 rows are shown in the list, the horizontal position of 1 row cannot be scrolled down to expand to show more rows;

I can't reproduce the scrolling issue you mentioned.

I suggest using the full mode (Alt+T for Windows/Linux, Command+T for macOS) for a better experience.

2,I can't seem to find the description here sort by what?

It's Group & Sort Tabs. It will group tabs by domain first (move tabs from the same domain into the same window) and sort the tabs by whether it's pinned, domain, url, and title. The implementation is here:

export const tabComparator = (a, b) => {
if (a.pinned ^ b.pinned) {
return b.pinned ? 1 : -1
}
if (a.domain !== b.domain) {
return a.domain.localeCompare(b.domain)
} else if (a.url !== b.url) {
return a.url.localeCompare(b.url)
} else if (a.title !== b.title) {
return a.title.localeCompare(b.title)
}
return a.index - b.index
}

@xcv58
Copy link
Owner

xcv58 commented Dec 8, 2022

For the scrolling issue, could you please try to drag the right-side scrollbar to see whether you can move the view?

@wxlg1117
Copy link
Author

wxlg1117 commented Dec 8, 2022

1.At first I installed version 1.18.2 in the EDGE store, then I reinstalled version 1.21.3 in the google store, and the problem disappeared.
2.I get it.

found a small problem again, win7 x64 +edge, click on the extension to expand the tabs list, the mouse pulls the right side of the scroll bar when the mouse does not follow the scroll bar click position, see the video (win7 + firefox or win10 +chrome are not this problem).

https://youtube.com/shorts/e4KFlV8Ue8Y

@xcv58
Copy link
Owner

xcv58 commented Dec 8, 2022

Got it, thank you for the update.

I will publish the new version in Edge store.

Will tackle the video issue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants