Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To return or not to return Dataset/DataArray during validate #12

Open
orianac opened this issue Dec 2, 2021 · 1 comment
Open

To return or not to return Dataset/DataArray during validate #12

orianac opened this issue Dec 2, 2021 · 1 comment

Comments

@orianac
Copy link
Contributor

orianac commented Dec 2, 2021

Before the major reorg validate returned a DataArray or Dataset but now it doesn't. Was that intentional @jhamman ? Or should we add back in the return? I personally like the idea of not returning it - I think it makes the focus on whether or not it raises the error compared to passing around the object with unnecessary variable assignments - but want to make sure it's intentional before we update codebases elsewhere. @norlandrhagen

@jhamman
Copy link
Contributor

jhamman commented Dec 2, 2021

Yes, this was intentional. Pandera includes a bunch of options for coercing data into compliance with the schema but I think that should be out of scope here (at least for now). So during the refactor, I opted to forgo the return during validate in hopes of clarifying the intention of the validate method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants