Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] iOS PlatformSpecific for UISlider #1729

Closed
rmarinho opened this issue Jan 29, 2018 · 3 comments · Fixed by #2476
Closed

[Enhancement] iOS PlatformSpecific for UISlider #1729

rmarinho opened this issue Jan 29, 2018 · 3 comments · Fixed by #2476

Comments

@rmarinho
Copy link
Member

rmarinho commented Jan 29, 2018

Rationale

There is currently no way to to set the value when tapping a slider on iOS

Implementation.

Add a PlatformSpecific property for Slider on iOS. Customer renderer changes to subscribe to the tap event, calculate position and set the value. `((IElementController)Element).SetValueFromRenderer(Slider.ValueProperty, Value)

Slider.On<iOS>().UpdateOnTap(true/false);

Expected Result

Android

None

iOS

Value of slider should be updated when tapping

UWP

None

Implications for CSS

None

Backward Compatibility

We should set default to false and make sure all custom renderers continue to work even with our implementation.
Should respect and have some UITest for InputTransparent and and IsEnabled properties.
Should work with a tap gesture by allowing bubbling of the event to the parent.

Difficulty: Easy

@pauldipietro pauldipietro added this to New in Triage Jan 29, 2018
@hartez hartez removed this from New in Triage Jan 29, 2018
@davidortinau davidortinau added this to Backlog in Enhancements Jan 29, 2018
@samhouts samhouts moved this from Backlog to Ready for Implementation in Enhancements Jan 29, 2018
@ctartamella
Copy link

I would like to take this one. @davidortinau

@davidortinau davidortinau self-assigned this Feb 1, 2018
@davidortinau davidortinau moved this from Ready for Implementation to In Progress in Enhancements Feb 1, 2018
@jassmith
Copy link

@ctartamella still working on this?

@henricm henricm assigned henricm and unassigned davidortinau Apr 12, 2018
@henricm
Copy link
Contributor

henricm commented Apr 12, 2018

@davidortinau I'll take a look on this now as it seems like there is no active work going on. Let me know if there is.

henricm added a commit to henricm/Xamarin.Forms that referenced this issue Apr 16, 2018
@samhouts samhouts added this to Ready in v3.1.0 via automation Apr 16, 2018
@samhouts samhouts moved this from Ready to In Progress in v3.1.0 Apr 16, 2018
henricm added a commit to henricm/Xamarin.Forms that referenced this issue May 3, 2018
henricm added a commit to henricm/Xamarin.Forms that referenced this issue May 3, 2018
Adding null-checks when receiving gesture event since
control may have been disposed/removed at this point.

Making sure to remove GestureRecognizer when disposing
renderer.

Refs xamarin#1729
v3.1.0 automation moved this from In Progress to Done May 3, 2018
Enhancements automation moved this from In Progress to Done May 3, 2018
rmarinho pushed a commit that referenced this issue May 3, 2018
…1729

* Adding support for tapping on iOS Slider to set value

Refs #1729

* Remove GestureRecognizer and added null checks

Adding null-checks when receiving gesture event since
control may have been disposed/removed at this point.

Making sure to remove GestureRecognizer when disposing
renderer.

Refs #1729
@samhouts samhouts removed this from Done in v3.1.0 May 7, 2018
@samhouts samhouts removed this from Done in Enhancements Jun 12, 2018
@samhouts samhouts added this to Done in v3.2.0 Jun 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v3.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants