Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Make it work on VSMac #15726

Closed
wants to merge 4 commits into from
Closed

Make it work on VSMac #15726

wants to merge 4 commits into from

Conversation

rmarinho
Copy link
Member

Housekeeping

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@@ -12,6 +12,7 @@
<Company>Microsoft</Company>
<Product>Xamarin.Forms</Product>
<ProduceReferenceAssembly Condition="'$(UsingMicrosoftNETSdk)' == 'True' AND '$(Configuration)' == 'Debug'">True</ProduceReferenceAssembly>
<BuildWithMSBuildOnMono>true</BuildWithMSBuildOnMono>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes VSMac happy

@@ -1,11 +1,4 @@
<Project>
<ItemGroup>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are duplicated and caused NuGet restore to fail

@@ -350,11 +350,6 @@
<PackageReference Include="Xam.Plugin.DeviceInfo">
<Version>3.0.2</Version>
</PackageReference>
<PackageReference Include="Xamarin.AndroidX.Legacy.Support.V4" Version="1.0.0.8" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to Nuget.Build.targets

@rmarinho rmarinho marked this pull request as ready for review April 14, 2023 17:40
@jfversluis
Copy link
Member

Won't be needed anymore with the incoming retirement soon.

@jfversluis jfversluis closed this Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants