Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fixing issue #15314 #15687

Closed
wants to merge 1 commit into from
Closed

Conversation

dennisstromberg
Copy link
Contributor

Description of Change

Before updating textdecorations in LabelRenderer, it is necessary to check if it is using FormattedText and if any of its spans are styled with TextDecorations. If this is the case, the process should return to avoid removing the existing styling.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

TextDecorations will now show when updating FormattedText after initial render.

Before/After Screenshots

Not applicable

Testing Procedure

Create a label with text and a button that setting the FormattedText in the codebehind.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis
Copy link
Member

jfversluis commented Feb 14, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

@jfversluis jfversluis closed this Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][iOS] TextDecorations property does not work on Span on iOS
2 participants