Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core] Make BindableLayout handle collection changed on the main thread #14798

Closed
wants to merge 1 commit into from

Conversation

GalaxiaGuy
Copy link
Contributor

@GalaxiaGuy GalaxiaGuy commented Oct 26, 2021

Description of Change

Changes the BindableLayout.ItemsSourceCollectionChanged method to handle changes on the main thread.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

There are unit tests that just confirm that BeginInvokeOnMainThread is called.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

@hartez What do you think, would you have any objection to this change?

@thisisthekap
Copy link
Contributor

@jfversluis Any chance that this one is making it into a Xamarin.Forms service release?

@jfversluis
Copy link
Member

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

@jfversluis jfversluis closed this Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BindableLayout does not marshal ObservableCollection.CollectionChanged to MainThread
4 participants