Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableNext doesn't actually disable anything by default #30

Open
Spacarar opened this issue Oct 28, 2020 · 0 comments
Open

disableNext doesn't actually disable anything by default #30

Spacarar opened this issue Oct 28, 2020 · 0 comments

Comments

@Spacarar
Copy link

I am using VGW 1.4.1 and maybe this is intended, but the nextDisabled property doesn't actually stop the button from being pressed.

To reproduce here is a minimal example

<template>
  <div>
    <vue-good-wizard name="fakeTour" :steps="steps">
      <div slot="companyInfo">
        company based content
      </div>
      <div slot="teamInfo">
        team based content
      </div>
      <div slot="userInfo">
        user based content
      </div>
    </vue-good-wizard>
  </div>
</template>

<script>
export default {
  computed: {
    steps () { // this will be dynamic based on other data properties, so that's why it's computed here
      return [
        {
          label: 'Company Information',
          slot: 'companyInfo',
          options: {
            nextDisabled: true
          }
        },
        {
          label: 'Teams',
          slot: 'teamInfo'
        },
        {
          label: 'Users',
          slot: 'userInfo'
        }
      ]
    }
  }

}
</script>

On the first screen you can see that the next button appears to be disabled and shows a disabled cursor when hovered, but you can still click the button and it will still take you to the next screen. I understand this could be worked around with a custom onNext function, but it seems like the button functionality should actually be disabled if it is visibly disabled.

Regardless of the issue, thanks for maintaining such a useful library, and please ignore the style changes I've made on the screenshot.

Screen Shot 2020-10-28 at 11 09 08 AM
Screen Shot 2020-10-28 at 11 09 12 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant