Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin.Badge is not working with FFImageLoading or Xamarin.Forms.Nuke on iOS #99

Open
2 of 7 tasks
acuntex opened this issue Oct 28, 2020 · 1 comment
Open
2 of 7 tasks
Labels
pr welcome A pull request adressing the issue is welcome up for grabs

Comments

@acuntex
Copy link

acuntex commented Oct 28, 2020

馃悰 Bug Report

When using Plugin.Badge in combination with FFImageLoading (and the method CachedImageRenderer.InitImageSourceHandler()) or Xamarin.Forms.Nuke (and the method Xamarin.Forms.Nuke.FormsHandler.Init()), the Badges are not shown. Only after changing the values of the badges, they are shown.

Since it is necessary to use either FFImageLoading or Xamarin.Forms.Nuke in any app that's getting slightly bigger and that's using images, compatibility is necessary.

Expected behavior

Plugin.Badge works together with FFImageLoading and Xamarin.Forms.Nuke.

Reproduction steps

  1. Install Plugin.Badge
  2. Install FFImageLoading or Xamarin.Forms.Nuke
  3. Call CachedImageRenderer.InitImageSourceHandler() or Xamarin.Forms.Nuke.FormsHandler.Init()
  4. Try to use Badges

See repro for FFImageloading: https://github.com/acuntex/PluginBadge_Bug
See repro for Xamarin.Forms.Nuke: https://github.com/acuntex/NukePluginBadge_Bug

Configuration

Version: 2.3.0

Platform:

  • 馃摫 iOS
  • 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 Xamarin.Forms
@xabre xabre added pr welcome A pull request adressing the issue is welcome up for grabs labels Nov 1, 2020
@michelmoorlag
Copy link

As for FFImageLoading, don't call
CachedImageRenderer.InitImageSourceHandler();
in your AppDeletegate.cs. But keep in mind that you can not use FFimageloading with Xamarin.Forms.Image (any more). In my case I was not using that anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr welcome A pull request adressing the issue is welcome up for grabs
Projects
None yet
Development

No branches or pull requests

3 participants