Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes regrid2 mapping output to input ordering #653

Merged
merged 2 commits into from
May 28, 2024

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented May 9, 2024

Description

Output dimensional order was always ..., Y, X where ... is all other dimensions. This would cause an error when adding bounds as the input dimensional ordering was used in this process.

This PR fixes the issue by correctly transposing the output data to the same ordering as the input data.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@github-actions github-actions bot added the type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 9, 2024
@jasonb5 jasonb5 changed the title Fixes mapping output to input ordering Fixes regrid2 mapping output to input ordering May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7745757) to head (b7f6fe9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #653   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1543      1544    +1     
=========================================
+ Hits          1543      1544    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomvothecoder tomvothecoder merged commit 07bfbba into main May 28, 2024
9 checks passed
@tomvothecoder tomvothecoder deleted the fix-output-transpose branch May 28, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
Status: Done
2 participants