Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Possibly spare 1 URL fetch call during _on_signin #8

Open
x1ddos opened this issue Oct 1, 2012 · 2 comments
Open

Possibly spare 1 URL fetch call during _on_signin #8

x1ddos opened this issue Oct 1, 2012 · 2 comments

Comments

@x1ddos
Copy link
Owner

x1ddos commented Oct 1, 2012

I'm thinking to make _get_<provider>_user_info() call optional. This way one could spare a URL fetch call when existing users sign in as their profile data have probably been already stored during some previous logins.

Additionally, this could make it easier for a backend profile fetch instead of doing it during the user facing request.

Would this be a good idea?

@conradwt
Copy link

conradwt commented Oct 1, 2012

@crhym3 This sounds like a very good idea.

@x1ddos
Copy link
Owner Author

x1ddos commented Oct 1, 2012

I'll try to come up with a CL during this week and post it here for a review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants