You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dotfiles cannot be included in a sources.zip using includeSources (added in #378) after the changes made in #501: **/* passed to fast-glob doesn't match dotfiles without dot: true, so includeSources doesn't actually affect anything
Describe the bug
Dotfiles cannot be included in a
sources.zip
usingincludeSources
(added in #378) after the changes made in #501:**/*
passed tofast-glob
doesn't match dotfiles withoutdot: true
, soincludeSources
doesn't actually affect anythingwxt/src/core/zip.ts
Line 102 in 6b72f88
To Reproduce
wxt-zip-env.zip
pnpm i
pnpm zip:firefox
.env
file is included in.output/wxt-starter-0.0.0-sources.zip
If you downgrade
wxt
to0.17.4
,.env
file will be included insources.zip
Expected behavior
The dotfiles specified in
includeSources
must be included insources.zip
Environment
Additional context
Since
includeSources
are already globs, perhaps it is enough to just add them to theglob
sources?However, I'm not sure why
options.include
is passed tozipDir
wxt/src/core/zip.ts
Lines 63 to 65 in 6b72f88
but actually
wxt.config.zip.includeSources
is used insteadwxt/src/core/zip.ts
Lines 110 to 113 in 6b72f88
The text was updated successfully, but these errors were encountered: