Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 32bit arm #26

Open
igor-microblink opened this issue Mar 19, 2024 · 3 comments
Open

Add support for 32bit arm #26

igor-microblink opened this issue Mar 19, 2024 · 3 comments

Comments

@igor-microblink
Copy link

At the moment 32bit android arm is not supported, so the fallback without SIMD is required.

@wx257osn2
Copy link
Owner

wx257osn2 commented Apr 2, 2024

@igor-microblink Does this change fix this? If so, I will merge this into master . (I believe that this is one of the solution, but I don't have 32bit ARM environment, so can't check it.)

@igor-microblink
Copy link
Author

igor-microblink commented Apr 2, 2024

Thanks. Proposed change is fix for compilation error on armebi v7a.

__ARM_FEATURE_SVE is not defined for armeabi-v7a. Is it possible to add impl which utilizes arm neon for 32bit ARMs? AFAIK ARM NEON is supported from armeabi-v7.

@wx257osn2
Copy link
Owner

__ARM_FEATURE_SVE is not defined for armeabi-v7a

Yes, cause Arm SVE is an extension for armv8 and one of basic instructions in armv9.

Is it possible to add impl which utilizes arm neon for 32bit ARMs? AFAIK ARM NEON is supported from armeabi-v7.

Hmm, currently qoixx doesn't support armv7 as SIMD-available environment, because I don't have any development environment of armv7. It is possible technically cause NEON is an extension for armv7, but qoixx basically assumes 64-bit architecture (e.g. fast hash calculation using 64bit integer arithmetic; this might be not fast on 32bit environment), and currently I don't think I'd support it aggressively. Of course PR for supporting armv7 with NEON would be welcome, I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants