Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streams are UTF-8 #9

Open
jakecoffman opened this issue Feb 1, 2022 · 1 comment
Open

streams are UTF-8 #9

jakecoffman opened this issue Feb 1, 2022 · 1 comment

Comments

@jakecoffman
Copy link
Collaborator

Thanks to @kriive for pointing this out in #8.

Currently the streaming is counted by bytes, but it should be counted by UTF-8 rune.

In addition to updating Parse, we need to update ReadSome. Are there any other places?
jakecoffman added a commit that referenced this issue Feb 1, 2022
@jakecoffman
#9 guacamole streams are UTF-8
16c7931
@kriive
Copy link
Contributor

kriive commented Feb 1, 2022 •
edited

Yes, I guess Guacamole mostly uses ASCII (which maps to UTF-8 single byte) so it's understandable it didn't show up! Maybe if a user uses emojis in hostnames or password (oh dear...) it could cause some issues.

jakecoffman added a commit that referenced this issue Feb 1, 2022
@jakecoffman
#9 guacamole streams are UTF-8 (#10)
de992e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakecoffman @kriive