Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov report #218

Merged
merged 2 commits into from Nov 5, 2022
Merged

Conversation

Richard-Gist
Copy link
Collaborator

@Richard-Gist Richard-Gist commented Nov 5, 2022

Linked Issue:

#206

Checklist:

Documentation:

I'm not sure how to test this will actually fix the issue, but it does change the problem from not finding any coverage to finding at least 1 correct report.

@Richard-Gist Richard-Gist requested a review from a team as a code owner November 5, 2022 18:16
@Richard-Gist Richard-Gist linked an issue Nov 5, 2022 that may be closed by this pull request
1 task
@Richard-Gist
Copy link
Collaborator Author

Someone with more permissions needs to update the project to allow the new version of codecov:

 Error: .github#L1
codecov/codecov-action@v3 is not allowed to be used in wwt/SwiftCurrent. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, or matching the following: codecov/codecov-action@v1.5.2, jamesives/github-pages-deploy-action@4.1.3, mikepenz/release-changelog-builder-action@v1.7.3, ncipollo/release-action@v1, stefanzweifel/git-auto-commit-action@v4, urlstechie/urlchecker-action@master, slackapi/slack-github-action@v1.16.0, codecov/codecov-action@v3.0.0.

@Tyler-Keith-Thompson
Copy link
Collaborator

Apparently my account is no longer a member of the pipeline reviewers...gonna just override and move forward.

@Tyler-Keith-Thompson Tyler-Keith-Thompson added the maintenance Improvements or additions to configuration files label Nov 5, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit 75d0baf into main Nov 5, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson deleted the 206-codecov-report-on-readme-is-lying branch November 5, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements or additions to configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov report on README is lying
2 participants