V1 Refactor RC #327
Draft
V1 Refactor RC #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed project card.py - refactored selection, graph, subnet, segment from roadway network - refactored project changes apply from roadway network - refactored shapes, links and nodes specs from roadway network
+ varia bug fixes
transit selection tests passing
+ linting
- generalize transit property change projects to be any attribute in table
- update required link attr - pep8 - refactor time --> timespan
…n formats - Remove LocationReferences from required part of schema that we fill in. Jump straight to geometries. - Make link geometry creation a vector operation —> speeds up significantly 30-100 times as fast - Added - Accessor for link true-shapes - Add clipping functionality for roadway and transit
This was
linked to
issues
Apr 15, 2024
This was
linked to
issues
Apr 15, 2024
Now has enough nodes and transit to test most functionality - quickly and more importantly - easy to debug! Fixes #343
Now that selection dictionary is a data model and will default to none - need to not "select none"!
All transit tests passing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This. PR factors out methods from the RoadwayNetwork class in order to more easily understand and manage the combined functionality.
Selection: new class object which does segment-based or unique-id-based selection stored as dict in RoadwayNetwork objectgraph.py: functions related to osmnx and nx graph creation/translation and shortest path routingSegment: new class object with segment-finding functionsviz.py: folium charts (removes this dependency if isn't being used)/projects: module for each project type which has an apply script and supporting functionsTODO
networkwrangler/project cardQuestions
applyfor each kind?