Allow base scenario as scenario instance #299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #298 - Adds better/more accurate variable documentation and type-hinting - Adds test test_scenario_initialization()
DavidOry
requested changes
May 18, 2022
There was a problem hiding this comment.
- There are a lot of changes here, only a few related to allowing the
base_scenarioto be a scenario. Can we move the formatting and file moves to a separate PR? (This may not be a good use of our time with the current state of things, but worth asking). - Creating a default value for a new variable also seems to be a separate action. Can that be moved to a separate PR as well? (Same comment about it may not be worth it)
- I see a test using the
Scenarioconstructor, but not one with the staticcreate_scenariomethod. Can we add one withcreate_scenario? This is what Met Council has been using.
|
Need to review to see if overlapping with big PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298 to allow base scenario be a scenario instance.
Also includes various updates/fixes to typehints/docstrings in
scenario.pyand PEP8 updates.Tested via:
test_scenario_initialization()