Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Initialize scenario with base scenario as Scenario instance not just dictionary #298

Open
e-lo opened this issue Apr 22, 2022 · 0 comments · May be fixed by #299
Open

[FEATURE] Initialize scenario with base scenario as Scenario instance not just dictionary #298

e-lo opened this issue Apr 22, 2022 · 0 comments · May be fixed by #299
Assignees
@e-lo
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@e-lo
Copy link
Collaborator

e-lo commented Apr 22, 2022

User Story

As a user, I'd like to initialize a scenario with an scenario instance rather than having to access its dict attribute.

Priority

Med

Level of Effort

Low

Resolution Ideas

As implemented in "works with ranch" branch: allow either.

Tests

What are relevant tests or what tests need to be created in order to determine that this issue is complete?
Added test: test_scenario_initialization()
@e-lo e-lo added the enhancement New feature or request label Apr 22, 2022
@e-lo e-lo added this to the v1.0 milestone Apr 22, 2022
@e-lo e-lo self-assigned this Apr 22, 2022
e-lo added a commit that referenced this issue Apr 22, 2022
@e-lo
Allow base scenario as scenario instance
605b0cc 
Fixes #298

- Adds better/more accurate variable documentation and type-hinting
- Adds test test_scenario_initialization()
@e-lo e-lo linked a pull request Apr 22, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-lo e-lo

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Allow base scenario as scenario instance wsp-sag/network_wrangler
1 participant
@e-lo