Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TODOs #2

Open
Infernio opened this issue Jan 7, 2024 · 0 comments
Open

Some TODOs #2

Infernio opened this issue Jan 7, 2024 · 0 comments

Comments

@Infernio
Copy link
Member

Infernio commented Jan 7, 2024

  • Most of the stuff in package() should be moved to a WB script, e.g. scripts/configure.py, so that we can maintain it upstream in-tree.
  • WB is not at all prepared to handle idiomatic Linux. Some quick notes:
    • BashBugDump would need to be moved to e.g. ~/.local/share/wrye-bash/BashBugDump.log - ref Rework Logging wrye-bash#352
    • bash_default.ini is not necessary (package managers and users are used to dealing with changing config files and have backup/diff/merge tools for handling this, see backup= line below), but the config should go to e.g. /etc/wrye-bash.d/bash.ini, with a layered config in ~/.config/wrye-bash/bash.ini (this is a great idea no matter what, we should add it to Windows as well - plus we'll probably need another INI layer once we get around to profiles anyway - ref Profiles wrye-bash#250)
    • The docs should move to /usr/share/doc/wrye-bash (this is an issue since we have several buttons in WB for opening the docs)
    • The license should move to /usr/share/licenses/wrye-bash (not an issue, can be done in the script)
    • Bonus points for moving out of /opt entirely and sticking our shared stuff into /usr/share, our code into /usr/lib/python3.12/, etc.
  • I've marked some stuff as required that is technically optional, to improve the default user experience - maybe we should follow suit upstream? Full list:
    • binutils (for reading versions of Windows binaries - marked required because it's so common (installed on 99.22% of Arch Linux machines))
    • python-reflink (for making reflinks on appropriate filesystems - only 12.01% installed, but it's tiny and users of Btrfs/XFS/ZFS will really appreciate it)
    • xdg-utils (for opening folders, files, etc. - 89.43% installed)
  • I've also removed python-packaging as a dependency, since it's useless with update checking enabled (and update checking is pointless with a package manager)
  • PKGBUILDs should generally not download during prepare() etc., so we should do something about our usage of scripts/update_taglist.py in there
    • Maybe store a hash corresponding the used version of each taglist somewhere, then bump that when we download new taglists? That way we could add the LOOT repos as git sources with the release hashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant