Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugin-specific and theme-specifc rulesets #180

Open
3 tasks
jeffpaul opened this issue Apr 2, 2019 · 5 comments
Open
3 tasks

Support plugin-specific and theme-specifc rulesets #180

jeffpaul opened this issue Apr 2, 2019 · 5 comments

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Apr 2, 2019

Issue Overview

@jrfnl has created example code highlighting possible rulesets for plugins and themes (instead of using the full WPCS core ruleset). We should look to support these rulesets for plugin and theme reviews.

Expected Behavior

Add in two new rulesets to support specific reviews for plugins and themes.

Current Behavior

We currently audit plugins and themes against the full WPCS core ruleset and PHP Compat.

Todos

  • Tests
  • Documentation
  • Code
@jeffpaul jeffpaul added this to the Future Release milestone Apr 2, 2019
@grappler
Copy link
Contributor

As discussed with @valendesigns at WCEU contributor day there is a ruleset for themes: https://github.com/WPTRT/WPThemeReview

It is stable but more rulesets will be added/updated in the future.

@jeffpaul
Copy link
Member Author

@grappler in that case, should we split this into two issues (one for plugins and one for themes)? Possibly leaving this one for plugins and creating a new one for themes using details from the ruleset the TRT created?

@jrfnl
Copy link

jrfnl commented Jun 24, 2019

@jeffpaul Short summary of what was decided regarding this during the meeting at WCEU:

  • The TRT repo will be renamed to a more generic name and moved to the wp.org GH account.
  • In the (near) future, the repo will contain:
    • a Review sniffs directory which should not be directly used, this will (and does) contain theme/plugin review specific sniffs which are too specific for WPCS.
    • a ThemeReview ruleset
    • a PluginReview ruleset
    • one or more Tide rulesets
  • @grappler @dingo-d @Ipstenu @valendesigns and me will have all have admin/commit access to the repo

@jeffpaul
Copy link
Member Author

@jrfnl are the theme and plugin specific rulesets available and in a state that Tide should switch to using those?

@dingo-d
Copy link

dingo-d commented Sep 22, 2019

WPThemeReview has some new features, but also has an issue with false positives, especially in escaping and prefixing sniffs. It can be used (it's used in Twenty Twenty theme), but a lot of work needs to be done on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants