Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Detect Themify Builder Plugin? #80

Closed
jbma opened this issue Jul 6, 2016 · 6 comments
Closed

Auto-Detect Themify Builder Plugin? #80

jbma opened this issue Jul 6, 2016 · 6 comments
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: cache needs: testing question

Comments

@jbma
Copy link
Contributor

jbma commented Jul 6, 2016

The cache option within Themify's Builder plugin conflicts with WP Rocket, producing this issue: http://docs.wp-rocket.me/article/52-fix-for-weird-characters-displaying-on-your-web-page
Could we auto-detect it and display a warning to the user telling them to disable the Builder cache?

@jbma jbma added the question label Jul 6, 2016
@jbma
Copy link
Contributor Author

jbma commented Jul 6, 2016

Probably, do we have a testing site with it?

@Tabrisrp Tabrisrp added the 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting label Mar 8, 2018
@arunbasillal
Copy link
Contributor

I tested this with their plugin on the WordPress repo - https://wordpress.org/plugins/themify-builder/

Cache is disabled by default:
image

And we do not have very many tickets about this - https://secure.helpscout.net/search/?query=tag%3Athemify%20builder%20cache

  • Auto-compatibility is not required right now I think.
  • Most we could do is write to them to disable these things at their end when they detect WP Rocket.
  • For now we can just tell customer to disable the conflicting option.

@GeekPress Please note.

@GeekPress
Copy link
Contributor

@arunbasillal It could be good to contact their team and ask them to make an auto-compatibility with caching plugins.

@webtrainingwheels Can you take the lead to contact them?

@webtrainingwheels
Copy link

@kierantaylorio has contacted them here: https://secure.helpscout.net/conversation/1178151436/168605/

@kierantaylorio
Copy link
Contributor

kierantaylorio commented May 29, 2020

@arunbasillal Themify have responded and are happy to look into this with you: https://secure.helpscout.net/conversation/1178151436/168605

Update on 09 September 2020. Conversation continued here: https://secure.helpscout.net/conversation/1276792783/#thread-3662844358

@piotrbak
Copy link
Contributor

I can see that Cache option is not available there anymore and all performance settings (browser caching and gzip) are disabled by default. The plugin is just 10k installs and we have 4 tickets related to it during a couple of years. We can easily close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: cache needs: testing question
Projects
None yet
Development

No branches or pull requests

7 participants