Rollback to more than one version backward leads to upgrade to latest version

[engahmeds3ed]

Before submitting an issue please check that you’ve completed the following steps:

• Made sure you’re on the latest version Yes
• Used the search feature to ensure that the bug hasn’t been reported before Yes

Describe the bug
When trying to rollback for more than one time this leads to upgrade instead of multiple rollbacks.

To Reproduce
Steps to reproduce the behavior:

1. I have 3.7.0.1 installled.
2. I rollback to 3.6.4 and this happened successfully
3. from that I try to rollback to 3.5.5.1.
4. Instead it updates to 3.7.0.1

Expected behavior
we have two scenarios here:-

1. not to rollback more than one time and here we need to adjust the rollback button text to express that it will update or show error message for example.
2. Open the number of rollbacks and adjust the functionality of the button when user rollback more than one time.

Screenshots
First rollback from 3.7.0.1 to 3.6.4

Second rollback from 3.6.4 to 3.5.5.1

Additional context
We need product input here

Backlog Grooming (for WP Media dev team use only)

• Reproduce the problem
• Identify the root cause
• Scope a solution
• Estimate the effort

[arunbasillal]

Open the number of rollbacks and adjust the functionality of the button when user rollback more than one time.

I always thought that the rollback would keep on rolling back. So this is what I think should happen.

• Let's say a user rolls back to 3.6.4. This WP Rocket should look and behave exactly like when the user installed 3.6.4 the first time.
• The last stable is hardcoded within WP Rocket. A user on 3.6.4 would expect to rollback to the stable one before that and so on.
• If the user wants to get the latest version, then they can always update.
• But if the user (for whatever reason) wants to go back, doing multiple rollbacks is the only way.

Inviting @GeekPress here.

[GeekPress]

This isn't the expected behavior. If we want to rollback twice for any reasons, we should be able to do it.

[engahmeds3ed]

Reproduce the problem
Yes reproduced locally and on one of our customer sites.
When rollback to 3.6.4 I can see on the rollback button at WPR admin (tools) that we can rollback to 3.5.5.1 and when clicking on it, it updates to 3.7.0.1

Identify the root cause

wp-rocket/inc/classes/subscriber/Plugin/class-updater-subscriber.php

Lines 247 to 249 in 5434080

	if ( version_compare( $this->plugin_version, $remote_data->new_version, '<' ) ) {
	$transient_value->response[ $remote_data->plugin ] = $remote_data;
	}

this line is checking Wordpress plugin latest version and if the latest version is newer than the current version it will add the newer always
I got a question on my mind: why it's rolling back from 3.7.0.1 to 3.6.4 and the answer simply: current version on plugin code is 3.7.0.1 and latest version is 3.7.0.1 so it won't go into this condition.

Scope a solution

wp-rocket/inc/classes/subscriber/Plugin/class-updater-subscriber.php

Lines 247 to 249 in 5434080

	if ( version_compare( $this->plugin_version, $remote_data->new_version, '<' ) ) {
	$transient_value->response[ $remote_data->plugin ] = $remote_data;
	}

this code is called when updating and when rollback so inside rollback function

wp-rocket/inc/admin/admin.php

Line 204 in 2b2fe80

function rocket_rollback() {

we will define a new constant and check on the first code to stop checking on the last version number.

also add a check on the last version to stop on is: 2.3.7

Estimate the effort
[S]: to check also this code with the team as I can see duplication here:

wp-rocket/inc/classes/class-wp-rocket-requirements-check.php

Line 173 in 58b612d

public function rollback() {

@arunbasillal Please confirm that the last version to stop on is: 2.3.7 as we started using WP_ROCKET_LASTVERSION constant.

[arunbasillal]

@engahmeds3ed

@arunbasillal Please confirm that the last version to stop on is: 2.3.7 as we started using WP_ROCKET_LASTVERSION constant.

I went back quite a lot and this commit confirms that 2.3.7 is indeed the last version - f5e1b8c

Thank you 👍

[NataliaDrause]

related: https://secure.helpscout.net/conversation/1820779650/332543?folderId=3864740

[CrochetFeve0251]

@piotrbak We have a problem concerning the grooming here and we discussed with @engahmeds3ed about it.
If the solution works for the changed version and the future ones this won't be applied to previous version that will be still running the old code.
Due to that we need to decide until where it is possible to rollback. Should it be until the updated version or until 2.3.7 that would the problem resurface as soon as the user backup with a version that has the old backup logic.

[NataliaDrause]

Related: https://secure.helpscout.net/conversation/1857583117/338858?folderId=3864740