Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare empty error #2295

Closed
piotrbak opened this issue Feb 4, 2020 · 4 comments
Closed

Cloudflare empty error #2295

piotrbak opened this issue Feb 4, 2020 · 4 comments
Labels
module: cloudflare type: bug Indicates an unexpected problem or unintended behavior

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Feb 4, 2020

When recreating a specific scenario WP Rocket will display the following output:
image

Steps to reproduce:

  1. Fill the wrong Cloudflare details
  2. Save options
  3. Switch Cloudflare to the Development Mode or turn on the Optimal Settings
  4. Save options

The error is caught here, but it's not displayed:

$errors[] = $error->message;

Errors that are logged when reproducing and they're not displayed:
2020-02-04 17:48:30] Error: Array ( [0] => Could not route to /zones/ZONE_ID/settings/development_mode, perhaps your object identifier is invalid? [1] => No route for that URI )

Related ticket:
https://secure.helpscout.net/conversation/1073800207/144348?folderId=2415573

@piotrbak
Copy link
Contributor Author

An empty error also occurs when enabling Cloudflare add-on for the first time and providing correct data. Steps to reproduce:

  1. Enable Cloudflare Add-on
  2. Provide correct data and enable Optimal Settings
  3. Save settings

Screencast:
https://jmp.sh/ax26MYQ

@Tabrisrp Tabrisrp added module: cloudflare needs: testing type: bug Indicates an unexpected problem or unintended behavior labels Feb 17, 2020
@Tabrisrp
Copy link
Contributor

Can you test if that issue is still present on 3.5 alpha when it's available?

@piotrbak
Copy link
Contributor Author

In 3.5 alpha the error message is still present but it's not empty. Scenario:
-Install WP Rocket
-Provide correct CF details
-Enable Optimal Settings
-Save settings

Error message:
Cloudflare email and/or API are not set
https://jmp.sh/QJpSkM7

@GeekPress
Copy link
Contributor

GeekPress commented Feb 27, 2020

Thanks @piotrbak for the feedback.

Could you please open a new issue with this behavior? We will close this one.

Why?
We are considering the original issue "fixed" as we don't have blank error anymore. Now we have multiple duplications of the message. It's a new bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cloudflare type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants