Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Facebook Pixel add-on breaks the Facebook Like/Share plugin #1326

Closed
vmanthos opened this issue Nov 9, 2018 · 6 comments
Closed

The Facebook Pixel add-on breaks the Facebook Like/Share plugin #1326

vmanthos opened this issue Nov 9, 2018 · 6 comments
Assignees
@crystinutzaa
Labels
type: bug Indicates an unexpected problem or unintended behavior wontfix Indicates that work won't continue on an issue or pull request
Milestone
3.4.3

Comments

@vmanthos
Copy link
Contributor

vmanthos commented Nov 9, 2018 •
edited by arunbasillal

When enabled, the Facebook Pixel add-on breaks the Facebook Like/Share Plugin.

To Reproduce

  1. Go to http://wealthweekly.com/contest?nocache. There is a Facebook Like/Share box there (https://vgy.me/UmTONB.jpg), which is embedded using an iframe.
  2. Go to http://wealthweekly.com/contest/
    The Like/Share box is gone.

We replace only the revision: value in comparison to the sdk.js that we fetch from Facebook. Check the diff here:
https://www.diffchecker.com/FT5VIg3v

Related Ticket
https://secure.helpscout.net/conversation/704013562/85513?folderId=2135277
@Tabrisrp Tabrisrp added type: bug Indicates an unexpected problem or unintended behavior Module: Facebook Pixel Addon labels Nov 9, 2018
@Tabrisrp Tabrisrp modified the milestone: 3.2.2 Nov 12, 2018
crystinutzaa added a commit that referenced this issue Dec 2, 2019
@crystinutzaa
Fixes: #1323,#1326 - Facebook Pixel Addon need to run FB.init()
a114172
@crystinutzaa crystinutzaa self-assigned this Dec 2, 2019
@crystinutzaa crystinutzaa added this to the 3.4.3 milestone Dec 2, 2019
crystinutzaa added a commit that referenced this issue Dec 4, 2019
@crystinutzaa
Merge pull request #2144 from wp-media/fix/1323-1326-facebook-pixel-a…
a90c19a 
…ddon-fb-init

Fixes: #1323,#1326 - Facebook Pixel Addon need to run FB.init()
@crystinutzaa
Copy link
Contributor

Fixed with v3.4.3 release

@alfonso100
Copy link
Contributor

alfonso100 commented Jun 17, 2020 •
edited

This issue was fixed and closed, but I've just encountered a very similar case here with WPR 3.5.5.1:
https://secure.helpscout.net/conversation/1178785091/168787/

If the Facebook Add-on is enabled, this likebox doesn't work: https://jmp.sh/dUFCT6O

Saved the JS files in the ticket for reference

@alfonso100 alfonso100 reopened this Jun 17, 2020
@GeekPress
Copy link
Contributor

@crystinutzaa Can you have a look to this?
@alfonso100 can you ask a FTP access? It will be easer for @crystinutzaa if we can try directly on the customer website.

Thanks =)

@crystinutzaa
Copy link
Contributor

@GeekPress sure. @alfonso100 please contact me when we have access and I will take a closer look

@piotrbak
Copy link
Contributor

Related ticket:
https://secure.helpscout.net/conversation/1233430729/182036?folderId=2415573

@GeekPress GeekPress added wontfix Indicates that work won't continue on an issue or pull request and removed waiting for feedback labels Apr 16, 2021
@GeekPress
Copy link
Contributor

Closing this issue as Facebook Pixels add-on will be removed in WP Rocket 3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crystinutzaa crystinutzaa

Labels
type: bug Indicates an unexpected problem or unintended behavior wontfix Indicates that work won't continue on an issue or pull request
Projects
None yet
Milestone
3.4.3
Development

No branches or pull requests
7 participants
@vmanthos @alfonso100 @GeekPress @Screenfeed @Tabrisrp @piotrbak @crystinutzaa