Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WordPress new Site Icon feature to generalSettings. #3099

Open
izzygld opened this issue Apr 11, 2024 · 2 comments
Open

Add WordPress new Site Icon feature to generalSettings. #3099

izzygld opened this issue Apr 11, 2024 · 2 comments
Labels
ObjectType: Settings Status: Discussion Requires a discussion to proceed Type: Enhancement New feature or request

Comments

@izzygld
Copy link
Contributor

izzygld commented Apr 11, 2024

What problem does this address?

Would love to have the siteIconUrl built in to the generalSettings

Screenshot 2024-04-11 at 16 17 15

What is your proposed solution?

'siteIconUrl'  => get_site_icon_url(),

function register_site_icon_url() {
    $args = [
      'type' => 'MediaItem',
    ];
    register_setting( 'group_settings', 'site_icon_url', $args );
}

add_action( 'init', 'register_site_icon_url' );

What alternatives have you considered?

No response

Additional Context

Happy to open a PR - just show me where the general settings is stored.

@justlevine
Copy link
Collaborator

Hey @izzygld

The reason you can't find it is that it doesn't exist 🙈, or rather that WPGraphQL currently only autoregisters settings that have a defined schema.

You can see some prior art in #661 , but work on this will probably be blocked until we ship the Experiments API (#3098 ) as part of the upcoming v2.0 release (#3081 )

@justlevine justlevine added Type: Enhancement New feature or request Status: Discussion Requires a discussion to proceed ObjectType: Settings labels Apr 11, 2024
@izzygld
Copy link
Contributor Author

izzygld commented Apr 11, 2024

thank you @justlevine.

Ok. keep us posted,

Happy to help out if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ObjectType: Settings Status: Discussion Requires a discussion to proceed Type: Enhancement New feature or request
Projects
Status: 💬 In Discussion
Development

No branches or pull requests

2 participants