chore!: update webonyx/graphql-php to 15.11.1 #3078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @kasparsd !
Indeed, until now it's only been mentioned as a blocker in the background of other tickets. We'll now be tracking in #3077 . I enabled the CIs so we have a reference point, but probably not worth remediating until we've got the 2.0 roadmap hammered out and are ready to begin work. |
|
Code Climate has analyzed commit 0040b61 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thank you for the confirmation @justlevine! I'll close this out then since you'll probably handle it as part of a larger changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Update the
webonyx/graphql-phpdependency from version 14.11.10 to the latest version 15.11.1 which includes the following changes webonyx/graphql-php@v14.11.10...v15.11.1Notable breaking changes are:
Require PHP 7.4 or later (a breaking change for this project which currently requires 7.1 as minimum).
The upgrade from PHP 7.1 was first introduced in 15.0 (see 15.x release changelog) which I assume explains the current lock to the v14.x version for this project.
Does this close any currently open issues?
closes #3077
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
This changeset requires an update to the minimum supported version of PHP which might need a larger discussion. I couldn't find an existing issue for that, though.
Where has this been tested?
Operating System: Ubuntu 23.10
WordPress Version: 6.4.3