Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to help automate version numbers during releases #3003

Open
2 of 3 tasks
justlevine opened this issue Dec 26, 2023 · 2 comments
Open
2 of 3 tasks

Add workflow to help automate version numbers during releases #3003

justlevine opened this issue Dec 26, 2023 · 2 comments
Labels
scope: build scripts Affects build scripts, CI workflows, and automation. Status: 🚀 Actionable Issues that have been curated, have enough info to take action, and are ready to be worked on Type: Chore (updating CI tasks etc; no production code change)

Comments

@justlevine
Copy link
Collaborator

Description

It seems we've been forgetting to update the WPGRAPHQL_VERSION since we moved it to constants.php

define( 'WPGRAPHQL_VERSION', '1.16.0' );

Steps to reproduce

add_action( 'plugins_loaded', static function() {
  if (  defined( 'WPGRAPHQL_VERSION' ) && version_compare( WPGRAPHQL_VERSION, '1.19.0, '<' ) ) {
    error_log( 'This should only get logged if the version is less than 1.19.0' );
  }
 } );

Additional context

Maybe we should create a release CI that automatically commits the version bump in all the places we need it (constants, headers, @since @todo, @deprecated @todo etc). Or just an official checklist.

WPGraphQL Version

1.19.0

WordPress Version

6.4.2

PHP Version

8.1.15

Additional environment details

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have disabled ALL plugins except for WPGraphQL.

  • Yes
  • My issue is with compatibility with a specific WordPress plugin, and I have listed all my installed plugins (and version info) above.
@justlevine justlevine added Type: Bug Something isn't working Status: 🚀 Actionable Issues that have been curated, have enough info to take action, and are ready to be worked on Regression Bug that caused a regression to a previously working feature labels Dec 26, 2023
@jasonbahl
Copy link
Collaborator

@justlevine thanks for catching this. And yes, I think it makes sense to automate this more to prevent this in the future. Will work on a script to help with this.

Thanks! 🙌🏻

@jasonbahl jasonbahl changed the title Regression: incorrect WPGRAPHQL_VERSION Add workflow to help automate version numbers during releases Jan 23, 2024
@justlevine justlevine added scope: build scripts Affects build scripts, CI workflows, and automation. Type: Chore (updating CI tasks etc; no production code change) and removed Type: Bug Something isn't working Regression Bug that caused a regression to a previously working feature labels Feb 20, 2024
@josephfusco
Copy link
Member

For reference, Faust.js handles this via a node script that runs before an automated release PR is created. https://github.com/wpengine/faustjs/blob/canary/scripts/versionPlugin.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: build scripts Affects build scripts, CI workflows, and automation. Status: 🚀 Actionable Issues that have been curated, have enough info to take action, and are ready to be worked on Type: Chore (updating CI tasks etc; no production code change)
Projects
Status: 🎯Actionable
Development

No branches or pull requests

3 participants