Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the generic terminology used for term and meta subcommand descriptions #166

Open
johnbillion opened this issue Apr 9, 2018 · 1 comment

Comments

@johnbillion
Copy link
Contributor

The descriptions for the second-level subcommands of wp post|user term|meta use generic "object" terminology from the method docblocks in the abstract CommandWithTerms and CommandWithMeta classes. For example:

  • wp post term --help correctly says "Adds, updates, removes, and lists post terms."
  • wp post term list --help uses the generic phrase "List all terms associated with an object."

Generic terminology is used for all four term and meta subcommands:

wp (post|user) (term|meta) (add|list|remove|set) --help

It would be great if the descriptions and argument synopses for these commands didn't use generic terminology.

@schlessera
Copy link
Member

This is because most of the code is in a shared abstract class, so the docblocks only exist once for all "objects".

I agree that it would be preferable to get rid of the generic terms, though. I'll have a look to see how best to achieve that without copying the logic around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants