Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal component don't support native modal mode #247

Open
sezaru opened this issue Mar 5, 2024 · 1 comment
Open

Modal component don't support native modal mode #247

sezaru opened this issue Mar 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sezaru
Copy link

sezaru commented Mar 5, 2024

Is your feature request related to a problem? Please describe.
The <dialog> element supports two ways to show its content, the first is modelessly which is the way that Doggo seems to support right now.

The second one with a modal mode that will make the dialog over the top of any other dialogs that might be present. Everything outside the dialog are inert with interactions outside the dialog being blocked.

More info here: https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement#instance_methods

Describe the solution you'd like
A way to show the dialog with modal mode which needs to call dialog.showModal() function (and also a way to do the same for closing it with the dialog.close() function.

Describe alternatives you've considered
I can implement this myself but I think it would be better to have built-in support in doggo since I believe that is the way most of users would want to use the dialog element.

@woylie
Copy link
Owner

woylie commented Mar 5, 2024

Thanks, makes sense to me. We don't bundle JavaScript yet, but as soon as we do, we can make the update.

@woylie woylie added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants