Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] ServerInfo is only used on client - rename to ClientConnectionInfo #67

Open
francy51 opened this issue Mar 5, 2020 · 1 comment
Open

[network] ServerInfo is only used on client - rename to ClientConnectionInfo #67

francy51 opened this issue Mar 5, 2020 · 1 comment

Comments

@francy51
Copy link
Contributor

francy51 commented Mar 5, 2020

There is no clear way of knowing which of the IPs declared in Project Configuration the server is being built to host on. ServerInfo could be renamed to ClientConnectionInfo to clarify this situation
@DX4D
Copy link
Collaborator

DX4D commented Mar 5, 2020

Turns out the server does not care what IP it is running on (only the port). Renaming of ServerInfo does still apply and would help clear up future confusion.

@DX4D DX4D changed the title [network] ip declared not clear [network] ServerInfo is only used on client - rename to ClientConnectionInfo Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@francy51 @DX4D