Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting quiet=TRUE in bm_raster doesn't make it run quietly #6

Open
simon-smart88 opened this issue Feb 13, 2024 · 2 comments
Open

Comments

@simon-smart88
Copy link

The documentation for bm_raster() says that setting quiet=TRUE will "Suppress output that show downloading progress and other messages." but if even when I set this, I get a download progress bar. This is especially inconvenient if you knit an Rmd containing a call to the function as it prints > 100 lines and there doesn't seem to be a way to suppress it.

I think the problem lies here:

response <- httr::GET(url,
and could be fixed by only including the progress() in that function if quiet = FALSE

@ramarty
Copy link
Contributor

ramarty commented Feb 19, 2024

@simon-smart88 Thanks for flagging this! Just made a fix in the development version, so if you install via:

devtools::install_github("worldbank/blackmarbler")

quiet=TRUE should work as expected. However, let me know if you still run into any issues. I'll get this to CRAN soon.

@simon-smart88
Copy link
Author

Yes all good now - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants