Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different join columns (parent_join_on, child_join_on) in relational model fit method. #27

Open
echatzikyriakidis opened this issue Jun 30, 2023 · 0 comments
Open

Use different join columns (parent_join_on, child_join_on) in relational model fit method. #27

echatzikyriakidis opened this issue Jun 30, 2023 · 0 comments

Comments

@echatzikyriakidis
Copy link

echatzikyriakidis commented Jun 30, 2023 •
edited

Hi @avsolatorio!

I was wondering if it easy to support for relational model fit() different columns for joining the data. Something like pandas merge supports: (left_on, right_on):

DataFrame.merge(right, ..., left_on=None, right_on=None, ...)

Maybe you could add support for parent_join_on, child_join_on?

Currently, it supports only join_on:

child_model.fit(
    df=child_df,
    in_df=parent_df,
    join_on=join_on)

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@echatzikyriakidis