Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing/maintainer guidelines #14

Open
sethvincent opened this issue Oct 4, 2016 · 5 comments
Open

Contributing/maintainer guidelines #14

sethvincent opened this issue Oct 4, 2016 · 5 comments

Comments

@sethvincent
Copy link
Contributor

@llkats mentioned this already (#10 (comment)) & I figured it would be useful to make an issue for it.

I've flopped javascripting over to this org & want to make sure I'm keeping up with and/or handing off maintenance responsibilities in an appropriate way.

It would be great to have contributing guidelines for newcomers as well as maintainers, including who's responsible for reviewing PRs, publishing releases of workshoppers, etc.

Basing it on node's contributing guidelines seems reasonable: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md

@martinheidegger
Copy link
Contributor

@sethvincent Seeing as I am really bad at this I would love if you champion it, and from my POV the Node contributing guidelines seem to make sense. Maybe we should also make the master branches protected (meaning: everything needs to be a PR)?

@denysdovhan
Copy link
Member

denysdovhan commented Oct 5, 2016

@martinheidegger btw, I've started an awesome-nodeschool list for those who want to get started as a attendee or host an event.

It would be great if we collect resources for contributors and maintainers of workshoppers.

@llkats
Copy link
Contributor

llkats commented Oct 5, 2016

As mentioned, I'd love to see a general CONTRIBUTING.md agreed upon and in all of the repos, as well as a standard process defined for contributing for all of the workshoppers (who merges the PRs, what a good PR looks like, etc.) Processes might need to be ironed out as we move towards more consistency with the different workshoppers. Making the master branches protected makes sense to me.

I personally think it'd be great to see original authors of workshoppers and/or current maintainers keep stewarding their projects! The how-to-npm workshopper references http://openopensource.org/ and I think it seems interesting insofar as rolling in new contributors - would love to hear peoples' thoughts on it.

@denysdovhan make sure to check out the wiki in nodeschool/organizers, there's a lot of material there for event organizers!

@llkats
Copy link
Contributor

llkats commented Oct 7, 2016

The latest episode of The Changelog RFC podcast has a ton of great discussion on open open source, ramping up contributors, establishing processes, etc.

@martinheidegger
Copy link
Contributor

I listened to the podcast episode (again, apparently😛 ) and agree with the basic sentiment that maintainers is everyone and that everyone should be empowered. The feeling of responsibility should come through proper attribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants