Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP FILE SERVER solution contains unnecessary/unexplained line #348

Open
piannaf opened this issue Sep 5, 2015 · 3 comments · May be fixed by #398
Open

HTTP FILE SERVER solution contains unnecessary/unexplained line #348

piannaf opened this issue Sep 5, 2015 · 3 comments · May be fixed by #398

Comments

@piannaf
Copy link

piannaf commented Sep 5, 2015

The solution includes the line

res.writeHead(200, {'content-type': 'text/plain'})

Neither the instructions nor the hints indicate the student should write this. Verification also doesn't test for this so it passes without.

Either:

  1. the solution should not have this line; or
  2. The instructions should make it necessary, the hints should mention writeHead, and verification should check the status code and headers

I err on the side of removing the line because this exercise isn't teaching HTTP.
@piannaf
Copy link
Author

piannaf commented Sep 9, 2015

Just noticed a TODO to add verification for this

@martinheidegger
Copy link
Contributor

@piannaf PR welcome :)

@jpdamon jpdamon linked a pull request Jan 4, 2016 that will close this issue
Open
@jpdamon
Copy link

jpdamon commented Jan 4, 2016

@martinheidegger I added the necessary changes to address this issue, however I still need some guidance for doing the verification. I notice that the test will still pass even if the fail event is emitted. Is there something else I need to be doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

verification of content-type and status code for http file server exercise jpdamon/learnyounode
3 participants
@piannaf @martinheidegger @jpdamon