Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling ProxyToWorker option has no effect #118

Open
sharifzadesina opened this issue Apr 9, 2023 · 3 comments
Open

Disabling ProxyToWorker option has no effect #118

sharifzadesina opened this issue Apr 9, 2023 · 3 comments

Comments

@sharifzadesina
Copy link

Hello,

It seems proxyToWorker: false option has no effects. the library still opens a worker and even closing the wallet doesn't close the worker.
This causes for example Jest show us a warning message: "A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.".

@sharifzadesina sharifzadesina changed the title Disable proxy to worker Proxy to worker has no effect Apr 9, 2023
@sharifzadesina sharifzadesina changed the title Proxy to worker has no effect Disabling proxy to worker has no effect Apr 9, 2023
@sharifzadesina sharifzadesina changed the title Disabling proxy to worker has no effect Disabling ProxyToWorker option has no effect Apr 9, 2023
@woodser
Copy link
Owner

woodser commented Apr 21, 2023

I don't see that a worker is created with proxyToWorker: false. For example:

let walletFull = await monerojs.createWalletFull({
  password: "abctesting123",
  networkType: "testnet",
  serverUri: "http://localhost:28081",
  proxyToWorker: false,
  rejectUnauthorized: false
});

Never executes LibraryUtils.getWorker(). Can you provide detailed steps to reproduce?

@sharifzadesina
Copy link
Author

@woodser It is just Jest warning message.

@woodser
Copy link
Owner

woodser commented May 10, 2023

If it helps, you can call:

  // terminate monero-javascript worker
  (await monerojs.LibraryUtils.getWorker()).terminate();

But there may very well be something else at play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants