Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent refactor: the agent should decrypt, rather than sending the unwrapped key #652

Open
woodruffw opened this issue Dec 26, 2023 · 0 comments

Comments

@woodruffw
Copy link
Owner

I've been meaning to do this for a while: there's no reason for the unwrapped key to be spread across both the client and the agent. The agent should instead hold onto it, and service requests from the client to perform decryption.

The main "pro" here is isolation of concerns. The main "con" is that it'll probably be slightly slower (especially for lots of decryptions in a row), but probably not distinguishable for the average use case.

This will require a protocol breakage on the agent side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant