Show why a step was skipped

[Andre601]

Clear and concise description of the problem

Right now a step is displayed as being cancelled, even tho it was actually skipped by not having its when condition fulfilled.

As an example, a when: {status: "failure"} step is displayed as cancelled when the pipeline was successfull, instead of it actually being skipped (Haven't even been run).

Suggested solution

The UI should clearls display a step as being skipped instead of cancelled when it has not been run due to conditions not being met.
This would help keeping a clear difference between a step that was cancelled (i.e. due to an issue) and one that simply wasn't executed.

Alternative

No response

Additional context

No response

Validations

• Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[qwerty287]

Did you check that in the db/raw data? Because I think it actually marks them as skipped but the ui shows the same for canceled and skipped.

[Andre601]

I'm talking about the UI itself, which always shows as cancelled like you mentioned.

[zc-devs]

There is too little information in the bug(?). @Andre601, could you add steps to reproduce?

---

Woodpecker 2.3.0, Kubernetes, pipeline.yaml.

Manual run, which failed in the middle

Next manual run with SKIP_IMAGE=true, SKIP_PUBLISH_QUAY=true

Edit: a little bit of clarification:

1. After fail, steps are in 'skipped' statuses
2. In the second run the skipped by the when filter steps are not displayed at all.

---

Also there is summary issue for statuses.

[qwerty287]

Took a look again and @Andre601 canceled and skipped actually have different icons in UI.

So the issue is: If a step is skipped due to conditions and if a step is skipped because a previous one failed, both get the skipped state which is correct and should be the same, because both are skipped. Just the reason is different. Maybe we can add something similar to #3532 for skipped steps too, but I'm against changing the status of such steps.