Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent-wide node selector (K8s) #3587

Open
3 tasks done
zc-devs opened this issue Apr 2, 2024 · 0 comments · May be fixed by #3608
Open
3 tasks done

Agent-wide node selector (K8s) #3587

zc-devs opened this issue Apr 2, 2024 · 0 comments · May be fixed by #3608
Labels
backend/kubernetes enhancement improve existing features

Comments

@zc-devs
Copy link
Contributor

zc-devs commented Apr 2, 2024

Clear and concise description of the problem

Allow admin to define Agent-wide node selector like it is with labels and annotations. Not using beta API or third party controllers.

See #3367.

Also from Matrix:

is there any way to set tolarations and affinity as default for pipelines in the backend for the kubernetes agent?

Although I'm about node selector, but

i would rather not fiddle around with my cluster settings to enable an alpha feature

the backend_options is basically exactly what i am looking for, but i would love to be able to specify them in the agent deployment instead of having to modify all my pipelines or remember to add that if i create a new pipeline for a new project

Maybe Cronix could define Agent-wide node selector and select Agent by labels then.

Suggested solution

Add Agent option WOODPECKER_BACKEND_K8S_POD_NODE_SELECTOR (woodpecker_backend_k8s_pod_labels)

Alternative

PodNodeSelector, v1.5 alpha.
Kyverno and similar, third party.

Additional context

No response

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@zc-devs zc-devs added the feature add new functionality label Apr 2, 2024
@qwerty287 qwerty287 added enhancement improve existing features backend/kubernetes and removed feature add new functionality labels Apr 3, 2024
@zc-devs zc-devs linked a pull request Apr 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/kubernetes enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants